Skip to content

Bump ruff from 0.17.3 to 0.17.4 in /.github/actions/python-tool-pins - #3948

Merged
ptr727-codegen[bot] merged 1 commit into
developfrom
dependabot/pip/dot-github/actions/python-tool-pins/develop/ruff-0.17.4
Nov 10, 2026
Merged

ptr727-codegen[bot] merged 1 commit into
developfrom
dependabot/pip/dot-github/actions/python-tool-pins/develop/ruff-0.17.4

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Bumps ruff from 0.17.3 to 0.17.4.

Release notes

Sourced from ruff's releases.

0.17.4

Release Notes

Released on 2026-11-05.

Preview features

  • [flake8-logging-format] Avoid behavior changes and syntax errors in fixes (G004) (#27419)
  • [security] Implement tarfile-ignore-zeros-true (#28680)

Bug fixes

  • Accept a bare raise before a semicolon (#29761)
  • Allow match identifiers after a semicolon (#29760)
  • Fix panic on BOM-prefixed files in diagnostic renderer (#30017)
  • [flake8-simplify] Report collapsible elif clauses after a multi-statement if branch (SIM102) (#29814)

Rule changes

  • Show more nonprinting characters in diagnostic fix diffs (#30062)

Performance

  • Coalesce source slices when formatting attributes (#29841)
  • Collect return statements with a statement-only visitor (#29911)
  • [pyflakes] Defer value comparisons for repeated dictionary keys (F601, F602) (#29739)
  • Format node fields directly when comment handling is unnecessary (#29853)
  • Reduce formatter source-slice overhead (#29855)
  • Reuse a callee's qualified name across lint rules (#29916)
  • Skip invalid string character checks when the source contains none (#29883)
  • Use a Bloom filter for formatter comment lookups (#29852)
  • Use a concrete buffer for ordinary writes (#29819)

CLI

  • Give NO_COLOR precedence in Ruff and ty diagnostics (#29898)
  • Honor CLICOLOR=0 in Ruff and ty diagnostics (#29910)

Documentation

  • Correct the documented version and src defaults for ruff-action (#29880)
  • [flake8-bugbear] Make B014 example error out-of-the-box (#29941)
  • [flake8-no-pep420] Document preview behavior (INP001) (#29764)
  • [isort] Expand I001 documentation (#29843)

Other changes

  • [syntax-errors] Extend __debug__ write check to attribute targets (#27908)

Contributors

... (truncated)

Changelog

Sourced from ruff's changelog.

0.17.4

Released on 2026-11-05.

Preview features

  • [flake8-logging-format] Avoid behavior changes and syntax errors in fixes (G004) (#27419)
  • [security] Implement tarfile-ignore-zeros-true (#28680)

Bug fixes

  • Accept a bare raise before a semicolon (#29761)
  • Allow match identifiers after a semicolon (#29760)
  • Fix panic on BOM-prefixed files in diagnostic renderer (#30017)
  • [flake8-simplify] Report collapsible elif clauses after a multi-statement if branch (SIM102) (#29814)

Rule changes

  • Show more nonprinting characters in diagnostic fix diffs (#30062)

Performance

  • Coalesce source slices when formatting attributes (#29841)
  • Collect return statements with a statement-only visitor (#29911)
  • [pyflakes] Defer value comparisons for repeated dictionary keys (F601, F602) (#29739)
  • Format node fields directly when comment handling is unnecessary (#29853)
  • Reduce formatter source-slice overhead (#29855)
  • Reuse a callee's qualified name across lint rules (#29916)
  • Skip invalid string character checks when the source contains none (#29883)
  • Use a Bloom filter for formatter comment lookups (#29852)
  • Use a concrete buffer for ordinary writes (#29819)

CLI

  • Give NO_COLOR precedence in Ruff and ty diagnostics (#29898)
  • Honor CLICOLOR=0 in Ruff and ty diagnostics (#29910)

Documentation

  • Correct the documented version and src defaults for ruff-action (#29880)
  • [flake8-bugbear] Make B014 example error out-of-the-box (#29941)
  • [flake8-no-pep420] Document preview behavior (INP001) (#29764)
  • [isort] Expand I001 documentation (#29843)

Other changes

  • [syntax-errors] Extend __debug__ write check to attribute targets (#27908)

Contributors

... (truncated)

Commits
  • 05cdc36 Bump version to 0.17.4 (#30073)
  • c6b17c2 [ty] Freshen method typevars before owner specialization (#29543)
  • 4b0b407 [ty] Preserve unions inferred during fixpoint iteration (#29927)
  • 1dd3e9e Show more nonprinting characters in diagnostic fix diffs (#30062)
  • 32be8e7 [ty] Skip fixpoint iteration for simple generic calls (#30054)
  • 926ccc8 [ty] Handle output errors when generating shell completions (#29997)
  • c86652a [ty] Skip active Conda and Pixi environments during discovery if the environm...
  • c9150f0 Add project walltime benchmarks for Ruff (#30061)
  • 64989ec [ty] Report invalid module globs once per override pattern (#30031)
  • 367a563 [ty] Fix conditional type and tuple annotations (#29987)
  • Additional commits viewable in compare view

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file python Pull requests that update python code labels Nov 9, 2026
@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@ptr727-codegen
ptr727-codegen Bot enabled auto-merge (squash) November 9, 2026 12:28
@codecov

codecov Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.76%. Comparing base (b38e084) to head (0a55fbd).
⚠️ Report is 126 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3948      +/-   ##
===========================================
- Coverage    81.60%   78.76%   -2.85%     
===========================================
  Files           26       37      +11     
  Lines         9070    12679    +3609     
===========================================
+ Hits          7402     9987    +2585     
- Misses        1668     2692    +1024     
Flag Coverage Δ
python-3.13 78.76% <ø> (-2.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727

ptr727 commented Nov 10, 2026

Copy link
Copy Markdown
Owner

@dependabot rebase

ptr727 added a commit that referenced this pull request Nov 10, 2026
## Summary

Ruff 0.17.4 reports SIM102 at `scripts/pr_review_copilot.py:550`. The
table branch of the Copilot findings reader nested a walrus `if` inside
its `elif`. That one error fails the lint job on the Dependabot ruff
bumps, #3948 into `develop` and #3949 into `main`.

The `table_cells(...) is not None` test now sits in the `elif`
condition, and the body is dedented. No `elif` or `else` follows that
branch, so when `table_cells` returns None nothing else runs, before or
after. `table_cells` has no side effects and still runs only after every
earlier condition holds.

## Verification

- `ruff check .` and `ruff format --check .` are clean under both 0.17.3
and 0.17.4.
- mypy is clean, and `tests/test_pr_review.py` and
`tests/test_pr_review_copilot.py` pass (631 tests).
- A recorded local strict review pass confirmed that behavior is
unchanged and found nothing.

🤖 Generated with [Claude Code](https://claude.com/claude-code)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

<!-- coderabbit-ai-generated:v1 -->

## Summary by CodeRabbit

* **Bug Fixes**
* Improved handling of invalid tables during pull request review,
preventing errors when reading table contents.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@ptr727

ptr727 commented Nov 10, 2026

Copy link
Copy Markdown
Owner

@dependabot rebase

Bumps [ruff](https://github.com/astral-sh/ruff) from 0.17.3 to 0.17.4.
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@0.17.3...0.17.4)

---
updated-dependencies:
- dependency-name: ruff
  dependency-version: 0.17.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/pip/dot-github/actions/python-tool-pins/develop/ruff-0.17.4 branch from b2b3877 to 0a55fbd Compare November 10, 2026 02:42
@ptr727-codegen
ptr727-codegen Bot merged commit 718e08e into develop Nov 10, 2026
13 checks passed
@ptr727-codegen
ptr727-codegen Bot deleted the dependabot/pip/dot-github/actions/python-tool-pins/develop/ruff-0.17.4 branch November 10, 2026 02:53
ptr727 added a commit that referenced this pull request Nov 10, 2026
## Summary

Promotes #4022 and #3948 to `main`.

- **Ruff 0.17.4 compatibility (#4022).** The Copilot findings reader's
table branch nested a walrus `if` inside its `elif`, which ruff 0.17.4
reports as SIM102. The condition now sits in the `elif`, and behavior is
unchanged.
- **Ruff 0.17.3 to 0.17.4 (#3948).** Dependabot's pin bump in
`.github/actions/python-tool-pins`, now passing lint after #4022.

## Review

- #4022 merged with a clean, attested local pass, all 13 checks green,
and Copilot recommending approval.
- #3948 merged through the merge bot once it was rebased onto #4022.

## After the merge

- `main` then pins ruff 0.17.4, so Dependabot's separate `main` bump,
#3949, has nothing left to change.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant