Repository navigation
Bump ruff from 0.17.3 to 0.17.4 in /.github/actions/python-tool-pins - #3949
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.17.3 to 0.17.4. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.17.3...0.17.4) --- updated-dependencies: - dependency-name: ruff dependency-version: 0.17.4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3949 +/- ##
=======================================
Coverage 78.66% 78.66%
=======================================
Files 37 37
Lines 12620 12620
=======================================
Hits 9928 9928
Misses 2692 2692
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
## Summary Ruff 0.17.4 reports SIM102 at `scripts/pr_review_copilot.py:550`. The table branch of the Copilot findings reader nested a walrus `if` inside its `elif`. That one error fails the lint job on the Dependabot ruff bumps, #3948 into `develop` and #3949 into `main`. The `table_cells(...) is not None` test now sits in the `elif` condition, and the body is dedented. No `elif` or `else` follows that branch, so when `table_cells` returns None nothing else runs, before or after. `table_cells` has no side effects and still runs only after every earlier condition holds. ## Verification - `ruff check .` and `ruff format --check .` are clean under both 0.17.3 and 0.17.4. - mypy is clean, and `tests/test_pr_review.py` and `tests/test_pr_review_copilot.py` pass (631 tests). - A recorded local strict review pass confirmed that behavior is unchanged and found nothing. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> <!-- coderabbit-ai-generated:v1 --> ## Summary by CodeRabbit * **Bug Fixes** * Improved handling of invalid tables during pull request review, preventing errors when reading table contents. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
## Summary Promotes #4022 and #3948 to `main`. - **Ruff 0.17.4 compatibility (#4022).** The Copilot findings reader's table branch nested a walrus `if` inside its `elif`, which ruff 0.17.4 reports as SIM102. The condition now sits in the `elif`, and behavior is unchanged. - **Ruff 0.17.3 to 0.17.4 (#3948).** Dependabot's pin bump in `.github/actions/python-tool-pins`, now passing lint after #4022. ## Review - #4022 merged with a clean, attested local pass, all 13 checks green, and Copilot recommending approval. - #3948 merged through the merge bot once it was rebased onto #4022. ## After the merge - `main` then pins ruff 0.17.4, so Dependabot's separate `main` bump, #3949, has nothing left to change. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
Looks like ruff is up-to-date now, so this is no longer needed. |
Pull request was closed
Bumps ruff from 0.17.3 to 0.17.4.
Release notes
Sourced from ruff's releases.
... (truncated)
Changelog
Sourced from ruff's changelog.
... (truncated)
Commits
05cdc36Bump version to 0.17.4 (#30073)c6b17c2[ty] Freshen method typevars before owner specialization (#29543)4b0b407[ty] Preserve unions inferred during fixpoint iteration (#29927)1dd3e9eShow more nonprinting characters in diagnostic fix diffs (#30062)32be8e7[ty] Skip fixpoint iteration for simple generic calls (#30054)926ccc8[ty] Handle output errors when generating shell completions (#29997)c86652a[ty] Skip active Conda and Pixi environments during discovery if the environm...c9150f0Add project walltime benchmarks for Ruff (#30061)64989ec[ty] Report invalid module globs once per override pattern (#30031)367a563[ty] Fix conditional type and tuple annotations (#29987)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)